Fix: Preservation package check fails when multiple copies of an item are already preserved (Issue 108) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
HafeezOJ
changed the title
zoidy
approved these changes
Oct 15, 2024
zoidy
deleted the
108-bug-preservation-package-check-fails-when-multiple-copies-of-an-item-are-already-preserved
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple copies of a preserved item exist in a remote storage, hash comparison is performed against just one copy during preservation package check (#102) which could lead to an assumption that the eventual preservation package does not exist and the item is sent for processing rather than been skipped.
This PR creates a list of an item's preserved copies hashes if any exist and the current hash is compared against hashes of all existing preserved copies. The item will be skipped if a match is found. A warning will be logged if multiple preserved copies are found for an item.