Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language button #98

Open
dennmuel opened this issue Aug 14, 2017 · 4 comments
Open

Language button #98

dennmuel opened this issue Aug 14, 2017 · 4 comments

Comments

@dennmuel
Copy link
Member

Should we add a button to change the language or do we want to keep it conditional to the browser language?

@wagneral
Copy link

Think we should add an additional button if it does not take a high effort.

Users don't necessary know what they have (installed) on their own or on lent devices. Furthermore language buttons are common for websites.

@dennmuel dennmuel removed the question label Aug 17, 2017
@dennmuel dennmuel changed the title Language button? Language button Aug 17, 2017
@dennmuel dennmuel self-assigned this Aug 17, 2017
dennmuel added a commit that referenced this issue Aug 17, 2017
@stweil
Copy link
Member

stweil commented Sep 22, 2017

The current implementation has some issues:

  • When I press the language button and select a language, the user interface switches to a different view. This is an unexpected behavior.
  • The language selection is currently not persistent. That limits its value.
  • What about a language selection during login?

@stweil stweil reopened this Sep 22, 2017
@dennmuel
Copy link
Member Author

Yes, the language selection causes the page to reload. It reloads to the control tab by default, which is an intended behaviour (makes sense e.g. after adding a content to be lead directly to where you can control said content). We could see how we could make the site reload to the section where the language selection is.

I am not sure what you mean by "not persistent", but I guess you mean, that the languages selectable are not all translated yet. This can be solved either by translating everything (long term solution) or by deleting the directories of untranslated languages (short term solution).

Language selection during login sounds like a good idea. Or does anyone else see any problem with this?

@stweil
Copy link
Member

stweil commented Sep 27, 2017

"Persistent" means that the chosen language should be saved as a cookie in the browser and used the next time(s) when PalMA is used again. Otherwise a user would have to select the language each time when (s)he uses PalMA.

@dennmuel dennmuel removed their assignment Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants