-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decently working state with improvements #1
Open
william-swy
wants to merge
63
commits into
UBC-Rocket:main
Choose a base branch
from
Ivan-Bao:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add gitignore for slprj to prevent possible problems - Add gitattributes to prevent slx and mat file corruption - Add csv for drag for easier viewing of dataset
File Management Changes
…he last computed landing spot deviates too much from the desired threshold. Also rearranged the way it plots data in matrix to make it more readable. +Added some documentation to make the code more comprehensive Caution: The y-coordinates of the output seems right, such that the center row are all zero because at the point the y-component of wind is zero. I am not sure about x-coordinates since it seems like the numbers are fluctuating. I know the rocket is launched at an angle, perhaps that's the reason?
- Solution temp as it is messy - Issue with some samples perhaps making integrator diverge
- drag force model now uses data from RASAero - remove RocketDragData.mat as it contains outdated data
…in the Main_Script, under rocket physical properties. I assumed everything is in SI units. I recommend people in Propulsion to check whether it looks reasonable, with only 1 cm of thrust offset, the rockets flied like a ballistic missile, and flipped 360 deg in the air.
…script, under the Thrust damping moment section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First thing to note: massive changes from baseline commit of 3248add
What changed:
Might be a good idea to keep the baseline code in a separate branch as there is some good stuff in there.