Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decently working state with improvements #1

Open
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

william-swy
Copy link

First thing to note: massive changes from baseline commit of 3248add

What changed:

  • Separated functions out. Makes the huge derivative calculator much easier on the eyes.
  • No more gimbal lock with angles close to 90 degrees
  • More flexible center of mass calculations. No more of what it appeared to be a polynomial spline? Moment of inertia calculations could be further improved
  • Some considerations of thrust misalignment but not perfect
  • Improved wind model. No more constant wind speed. Although it seems to significantly increase the runtime.
  • More flexible drag model. Takes in vehicle parameters.
  • Sampling is done in parallel. Improves runtime.
  • Some unit tests. There is more certainty that there is no bug with the math.

Might be a good idea to keep the baseline code in a separate branch as there is some good stuff in there.

william-swy and others added 30 commits October 14, 2020 18:09
- Add gitignore for slprj to prevent possible problems
- Add gitattributes to prevent slx and mat file corruption
- Add csv for drag for easier viewing of dataset
…he last computed landing spot deviates too much from the desired threshold.

Also rearranged the way it plots data in matrix to make it more readable.

+Added some documentation to make the code more comprehensive

Caution: The y-coordinates of the output seems right, such that the center row are all zero because at the point the y-component of wind is zero. I am not sure about x-coordinates since it seems like the numbers are fluctuating. I know the rocket is launched at an angle, perhaps that's the reason?
- Solution temp as it is messy
- Issue with some samples perhaps making integrator diverge
- drag force model now uses data from RASAero
- remove RocketDragData.mat as it contains outdated data
…in the Main_Script, under rocket physical properties.

I assumed everything is in SI units.
I recommend people in Propulsion to check whether it looks reasonable, with only 1 cm of thrust offset, the rockets flied like a ballistic missile, and flipped 360 deg in the air.
…script, under the Thrust damping moment section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants