Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp sample_package #362

Open
garethellis0 opened this issue Nov 10, 2018 · 0 comments
Open

Revamp sample_package #362

garethellis0 opened this issue Nov 10, 2018 · 0 comments
Assignees
@garethellis0

Comments

@garethellis0
Copy link
Collaborator

garethellis0 commented Nov 10, 2018 •
edited
Loading

Sample package is getting a little bit out of date. Here's a list of things that we should update:

  • move find_package(sb_utils REQUIRED) to just sb_utils under find_package(catkin ...
  • rename MyClass to MyNode
  • update package.xml to the newest version
  • change add_definitions(-std=c++14) to set(CMAKE_CXX_STANDARD 17) in CMakeLists.txt
  • change the header guards to #pragma once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethellis0 garethellis0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garethellis0 @raadkhan