Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄🐍 code - linting #47

Open
dpshelio opened this issue Nov 23, 2022 · 1 comment
Open

💄🐍 code - linting #47

dpshelio opened this issue Nov 23, 2022 · 1 comment
Labels
week07 Creating packages

Comments

@dpshelio
Copy link
Contributor

dpshelio commented Nov 23, 2022 •
edited by github-actions bot
Loading

  1. Analyse the awesome Charlene's package you've created (Creating a 🐍📦 with ℹ, 👷 and 📚 #46) and run one of the linting tools
    You may need to install them. Which messages did you get? Was your IDE (e.g., VS Code) warning you of it already?

  2. Fix them either manually or automatically using a code formatter (e.g., yapf or black)

  3. Can you think of a way of checking the style is checked before merging new contributions? Add your suggestions below 👇.

  4. Share your solution even if it's a work-in-progress as a pull request to Charlene's repository mentioning this issue (by including the text Addresses UCL-COMP0233-22-23/RSE-Classwork#47 in the pull request description), remember to mention your team members too! (with @github_username)
@dpshelio dpshelio added the week07 Creating packages label Nov 23, 2022
@bwan1 bwan1 mentioned this issue Nov 28, 2022
Open
@bwan1
Copy link

bwan1 commented Nov 28, 2022

You could include the CL linting command in the workflow yml file

@chongfengling chongfengling mentioned this issue Dec 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
week07 Creating packages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpshelio @bwan1