-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications for psmr2024 #1430
Open
NikEfth
wants to merge
83
commits into
master
Choose a base branch
from
modifications_for_psmr2024
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 81 commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
9e246fd
Adding support for singleTOF scanner.
NikEfth 4634d30
Fast reconstruction for LAFOV scanners
NikEfth 4ba55e6
Update src/buildblock/ProjDataInfo.cxx
NikEfth f5d663d
Update src/include/stir/ProjDataInfo.inl
NikEfth 438be2f
Update src/recon_buildblock/ProjMatrixByBin.cxx
NikEfth 0fb593d
Minor fixes and comments.
NikEfth 7bf7e52
Minor fixes and executable to cache listmode files without reconstruc…
NikEfth 6aa04b0
Update CMakeLists.txt
NikEfth 5fa949c
Update src/IO/InterfileHeader.cxx
NikEfth e67faec
Minor fixes
NikEfth e7a2656
Merge branch 'master' into modifications_for_psmr2024
NikEfth 9179482
Split GeneralisedPriorTests into several classes
KrisThielemans f7c15e6
fix abs() bug for RDP and slightly cleaner code
KrisThielemans a9c3ddb
change RDP Hessian behaviour at 0,0 when epsilon==0
KrisThielemans 005acb2
extra tests for the Relative Difference Prior
KrisThielemans b7f727d
make epsilon in numerical test for prior gradient a bit smaller
KrisThielemans d8b3826
fix and document RDP large limit test for numerical error
KrisThielemans f17a7b0
update RDP doc [ci skip]
KrisThielemans 619cc86
increase numerical precision of priors
KrisThielemans 32dc591
[GHA] remove explicit setting of xcode version
KrisThielemans fa21161
update Byte Order compile-time checks
KrisThielemans ead279e
fix white-space
KrisThielemans 205218d
List-mode objective function: always uses OpenMP for gradient
KrisThielemans eb31e8d
use more local variables in LM_distributable_computation
KrisThielemans 45a102c
prepare LM_distributable function for Hessian
KrisThielemans 7286488
minor clean-up and clarifications
NikEfth e1438a8
LM_listmode_function: implement Hessian and move functions
KrisThielemans 60445db
fix error when OpenMP is not present
KrisThielemans 7487039
Add compute_gradient* (as opposed to only subset)
KrisThielemans 055b17e
Move common test to ObjectiveFunctionTests
KrisThielemans e11fbf9
add numerical test for accumulate_Hessian_times_input
KrisThielemans 2315597
fix sign of LM Hessian
KrisThielemans 9022195
LM obj-fun: add value() and tests
KrisThielemans f2f29bd
LM objfun tests slightly better diagnostics
KrisThielemans 735e590
[GHA] upload ctest artefact if failure
KrisThielemans f3daa55
add "increment" test for gradient (enabled for LM data)
KrisThielemans 0be2403
[GHA] disabled LM objfunc test on MacOS
KrisThielemans db1d7b7
fix return value FastErf::get_maximum_sample_value
KrisThielemans 5864938
[CMake] force C++ version for more recent ROOT
KrisThielemans c813638
update to 6.1 and minor doc improvements
KrisThielemans a7bbe64
minor changes preparing for 6.1
KrisThielemans 58143b1
Changing all occurrences of abs() to std::abs() (#1425)
markus-jehl b7003ad
add TOF loop in computation of Hessian for projdata
KrisThielemans 1f6f8c5
fix set_up of norm in TOF ProjData gradient
KrisThielemans f4c1fb4
small rationalising of warnings
KrisThielemans 44af378
let git blame ignore some maintenance commits
KrisThielemans 23be801
updates to release notes
KrisThielemans d6231b0
update CITATION.cff according to git-fame
KrisThielemans 1180e45
small change to credits
KrisThielemans 4eac4ed
update history for release 6.1
KrisThielemans 4439d5f
change comment to avoid confusing doxygen [ci skip]
KrisThielemans 055f1c1
Merge remote-tracking branch 'refs/remotes/origin/modifications_for_p…
NikEfth 0d6516b
New utility to convert ProjData to FanProjData3D.
NikEfth 5c1af3f
Added option to load the model fanprojdata from the disk.
NikEfth a743a32
Update src/buildblock/Scanner.cxx
NikEfth c05dc3e
Fixes for test_time_of_flight.
NikEfth da59b78
minor fix
NikEfth fc36235
Fix to pass recon tests
NikEfth 21597d0
find ML normalization from listmode data.
NikEfth 9162578
Parallelization changes and labels
NikEfth 069231c
Important fix.
NikEfth 74fe00b
OpenMP parallelise Array::sum/find_max/find_min
KrisThielemans b297080
parallelise some functions in ML_norm
KrisThielemans 75b9d66
ML_norm estimation: avoid doing some block calculations if !do_block
KrisThielemans 3b56f1a
some ML_norm parallelisations
KrisThielemans c54c8a5
set KL_threshold to avoid problems
KrisThielemans 6c411d8
More parallelization.
NikEfth a455248
small fix
NikEfth 23cd5c4
fixes minor
NikEfth 9860aa3
parallellized apply_geo_norm
NikEfth e1149e2
Fix single TOF position
NikEfth 14f3cea
Print TOF
NikEfth 2100f42
extra documentation for ML_estimate_component_based_normalisation
KrisThielemans a5d816a
[SWIG] expose ML_estimate etc.
KrisThielemans a22c45c
remove hard-wired 50 threads
KrisThielemans 4aa5466
Some restructuring, needed.
NikEfth b1333e7
Merge remote-tracking branch 'refs/remotes/origin/modifications_for_p…
NikEfth 53c9d05
fix writing of single-TOF bin data
KrisThielemans 0c18fb6
another fix on tof data
KrisThielemans 9520af8
Merge remote-tracking branch 'origin/master' into modifications_for_p…
KrisThielemans 7eea917
fix Interfile writing of TOF data with 1 TOF bin
KrisThielemans d26b68a
replace std::cout calls with info()
KrisThielemans 34a35de
Merge remote-tracking branch 'origin/master' into modifications_for_p…
KrisThielemans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,7 +72,7 @@ FilePath::is_directory() const | |
struct stat info; | ||
|
||
if (stat(my_string.c_str(), &info) != 0) | ||
error(boost::format("FilePath: Cannot access %1%.") % my_string); | ||
warning(boost::format("FilePath: Cannot access %1%.") % my_string); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why did we make this change? |
||
else if (info.st_mode & S_IFDIR) | ||
return true; | ||
#endif | ||
|
@@ -92,7 +92,7 @@ FilePath::is_regular_file() const | |
struct stat info; | ||
|
||
if (stat(my_string.c_str(), &info) != 0) | ||
error(boost::format("FilePath: Cannot access %1%.") % my_string); | ||
warning(boost::format("FilePath: Cannot access %1%.") % my_string); | ||
else if (info.st_mode & S_IFREG) | ||
return true; | ||
#endif | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't need to add this.