Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose current_time in LmToProjData. #1525

Conversation

markus-jehl
Copy link
Contributor

@markus-jehl markus-jehl commented Oct 17, 2024

Changes in this pull request

Expose current_time in LmToProjData

Testing performed

Related issues

Fixes #1523

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

@KrisThielemans
Copy link
Collaborator

simple enough, but the name is probably confusing (it isn't the "current time" as far as LmToProjData goes). Maybe get_last_processed_lm_rel_time() or something like that?

@markus-jehl
Copy link
Contributor Author

simple enough, but the name is probably confusing (it isn't the "current time" as far as LmToProjData goes). Maybe get_last_processed_lm_rel_time() or something like that?

That make sense! Renamed it.

Copy link
Collaborator

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now please add a doxygne comment to the new function, sorry. i'll then squash-merge.

@KrisThielemans KrisThielemans added this to the v6.3 milestone Oct 21, 2024
@KrisThielemans KrisThielemans self-assigned this Oct 21, 2024
@KrisThielemans KrisThielemans merged commit 454be92 into UCL:master Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose current_time in lm_to_proj_data
2 participants