Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bins in mask for sinogram message to use info() #1542

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

robbietuk
Copy link
Collaborator

Changes in this pull request

This pull request includes a change to the CreateTailMaskFromACFs::process_data() function in the src/scatter_buildblock/CreateTailMaskFromACFs.cxx file to improve logging by replacing std::cout with the info function from the Boost library.

Testing performed

Works on my machine 😄

Related issues

Checklist before requesting a review

  • [] I have performed a self-review of my code
  • [] I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • [] The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

@robbietuk robbietuk self-assigned this Nov 21, 2024
@robbietuk robbietuk added this to the v6.3 milestone Nov 21, 2024
@KrisThielemans
Copy link
Collaborator

the info function from the Boost library.

obviously, info is from STIR 😄

Copy link
Collaborator

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit failures (i.e. formatting). Please follow instructions at https://github.com/UCL/STIR/blob/master/documentation/devel/git-hooks.md

Copy link
Collaborator

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to include boost/format.hpp explicitly to be on the safe side (or do we already?). Sorry that I didn't see this earlier

@KrisThielemans KrisThielemans merged commit b754fa7 into UCL:master Nov 23, 2024
9 checks passed
@robbietuk robbietuk deleted the info_message branch November 27, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants