Onesided setting produces uneven margins

[yeastbeast]

Hi,
Thanks for providing this great template.
I have noticed that the following results in uneven margins:
\documentclass[11pt,phd,a4paper,oneside]{ucl_thesis}

After some digigng, I think this is because the margin sizes in the cls just dont add up:

\setlength \voffset{-25.4mm}
\setlength \textwidth{140mm}
\setlength \textheight{232mm} % I think you need some extra vertical space for headers and page numbers
\setlength \topmargin{20mm}
\setlength \oddsidemargin {39mm} % Allow a mm for the bleed.
\if@twoside
  \setlength \evensidemargin {20mm}
\else
  \setlength \evensidemargin {39mm}
\fi

A4 paper is 210mm wide, but the textwidth plus the margins adds up to: 140 + 39 + 39 = 218

I guess this is causing the issue or is this intentional?

I changed the settings to

\if@twoside
  \setlength \oddsidemargin {40mm} % Allow a mm for the bleed.
  \setlength \evensidemargin {29mm}
\else
  \setlength \oddsidemargin {34.5mm} % Allow a mm for the bleed.
  \setlength \evensidemargin {34.5mm}
\fi

Doe you see any issues with that?

[vehstedt]

The uneven margins are deliberately set to allow room for binding the printed document. When single sided all numbered pages will be on the 'right' and will need the extra space for binding on the left side of the text, so you're getting:

Single sided:

• left pages: blank
• right pages: 39 + 140 + undefined margin (approx 31 mm)

Double-sided

• left pages: 20 + 140 + undefined margin (approx 50 mm)
• right pages: 39 + 140 + undefined margin (approx 31 mm)

The margins are set for the minimums given in UCL's thesis formatting guidance (and stated in the comments of the .cls file),

Margins at the binding edge must not be less than 40 mm (1.5 inches) and other margins not less than 20 mm (.75 inches).

I suspect the extra 10 mm may be to allow for additional things to go outside the text block, perhaps page or equation numbers, while still maintaining the minimum margin requirements.

[yeastbeast]

I see, thanks a lot for the clarification!
For printed and bound forms this all makes sense. However, I still think that for electronic versions of the thesis, it is better to have equal margins, would you agree? Just looks weird to have unequal margins when reading a pdf on a screen.
Anyways this is something everyone can quickkly sort out themselves I guess.