Skip to content

Commit 2951814

Browse files
author
David James
authored
Merge pull request #143 from chriswilliams13/http2_enabling
Added initial http2 functionality
2 parents d4ab1fd + d770367 commit 2951814

File tree

5 files changed

+39
-1
lines changed

5 files changed

+39
-1
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ This is useful when testing or for development instances or when a load-balancer
100100
* `SSL_SESSION_TIMEOUT` - Specifies a time during which a client may reuse the session parameters (defaults to 10min)
101101
* `HTTP_LISTEN_PORT` - Change the default inside the container from 10080.
102102
* `HTTPS_LISTEN_PORT` - Change the default inside the container from 10443.
103+
* `HTTP2` - Defaults to false `FALSE`. Specifies whether http2 should be used
103104
* `HTTPS_REDIRECT` - Toggle whether or not we force redirects to HTTPS. Defaults to true.
104105
* `ALLOW_COUNTRY_CSV` - List of [country codes](http://dev.maxmind.com/geoip/legacy/codes/iso3166/) to allow.
105106
* `STATSD_METRICS` - Toggle if metrics are logged to statsd (defaults to true)

build.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ pushd openresty
8787
--add-module="../naxsi/naxsi_src" \
8888
--add-module="../nginx-statsd" \
8989
--with-http_realip_module \
90+
--with-http_v2_module \
9091
--with-http_stub_status_module
9192
make install
9293
popd

ci-build.sh

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -604,6 +604,34 @@ else
604604
echo "Testing VERBOSE_ERROR_PAGES works..."
605605
fi
606606

607+
start_test "Test to ensure HTTP/2 is enabled when HTTP2 is set to true" "${STD_CMD} \
608+
-e \"PROXY_SERVICE_HOST=http://${MOCKSERVER}\" \
609+
-e \"PROXY_SERVICE_PORT=${MOCKSERVER_PORT}\" \
610+
-e \"DNSMASK=TRUE\" \
611+
-e \"ENABLE_UUID_PARAM=FALSE\" \
612+
-e \"HTTP2=TRUE\" \
613+
--link \"${MOCKSERVER}:${MOCKSERVER}\" "
614+
if curl -kv https://${DOCKER_HOST_NAME}:${PORT}/ 2>&1 | grep 'HTTP/2 200' ; then
615+
echo "Testing HTTP2 Works"
616+
else
617+
echo "HTTP2 didnt work"
618+
exit 1
619+
fi
620+
621+
start_test "Test to ensure HTTP/2 is disabled when HTTP2 is set to false" "${STD_CMD} \
622+
-e \"PROXY_SERVICE_HOST=http://${MOCKSERVER}\" \
623+
-e \"PROXY_SERVICE_PORT=${MOCKSERVER_PORT}\" \
624+
-e \"DNSMASK=TRUE\" \
625+
-e \"ENABLE_UUID_PARAM=FALSE\" \
626+
-e \"HTTP2=FALSE\" \
627+
--link \"${MOCKSERVER}:${MOCKSERVER}\" "
628+
if ! curl -kv https://${DOCKER_HOST_NAME}:${PORT}/ 2>&1 | grep 'HTTP/2 200' ; then
629+
echo "Testing HTTP2 FALSE Flag Works"
630+
else
631+
echo "HTTP2 FALSE didnt work"
632+
exit 1
633+
fi
634+
607635
echo "_________________________________"
608636
echo "We got here, ALL tests successful"
609637
clean_up

defaults.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export SSL_PROTOCOLS=${SSL_PROTOCOLS:-'TLSv1.2'}
1111
export SSL_SESSION_TIMEOUT=${SSL_SESSION_TIMEOUT:-'10m'}
1212
export HTTP_LISTEN_PORT=${HTTP_LISTEN_PORT:-10080}
1313
export HTTPS_LISTEN_PORT=${HTTPS_LISTEN_PORT:-10443}
14+
export HTTP2=${HTTP2:-'FALSE'}
1415
export HTTPS_REDIRECT=${HTTPS_REDIRECT:-'TRUE'}
1516
export NO_LOGGING_BODY=${NO_LOGGING_BODY:-'TRUE'}
1617
export NO_LOGGING_RESPONSE=${NO_LOGGING_RESPONSE:-'TRUE'}

go.sh

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ export LOG_UUID=FALSE
66

77
. /defaults.sh
88

9+
if [ "$HTTP2" = "TRUE" ]; then
10+
HTTP2="http2"
11+
else
12+
HTTP2=""
13+
fi
14+
15+
916
cat > ${NGIX_CONF_DIR}/server_certs.conf <<-EOF_CERT_CONF
1017
ssl_certificate ${SERVER_CERT};
1118
ssl_certificate_key ${SERVER_KEY};
@@ -51,7 +58,7 @@ else
5158
export REMOTE_IP_VAR="remote_addr"
5259
cat >> ${NGIX_LISTEN_CONF} <<-EOF-LISTEN-NONPP
5360
listen ${HTTP_LISTEN_PORT};
54-
listen ${HTTPS_LISTEN_PORT} ssl;
61+
listen ${HTTPS_LISTEN_PORT} ssl ${HTTP2};
5562
set \$real_client_ip_if_set '';
5663
EOF-LISTEN-NONPP
5764
fi

0 commit comments

Comments
 (0)