Skip to content

Commit d38f7bf

Browse files
author
David James
authored
Merge pull request #138 from UKHomeOffice/issue-2239
parameterised ssl_session_timeout
2 parents d8133a7 + a7aaba2 commit d38f7bf

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

.drone.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ steps:
5151
from_secret: docker_password
5252
DOCKER_REPO: artifactory-internal.digital.homeoffice.gov.uk
5353
DOCKER_USERNAME: docker-nginx-proxy-robot
54+
depends_on:
55+
- build_and_test_image
5456
when:
5557
event:
5658
- tag
@@ -67,6 +69,8 @@ steps:
6769
from_secret: docker_quay_password
6870
DOCKER_REPO: quay.io
6971
DOCKER_USERNAME: ukhomeofficedigital+nginx_proxy
72+
depends_on:
73+
- build_and_test_image
7074
when:
7175
event:
7276
- tag

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ This is useful when testing or for development instances or when a load-balancer
8080
* `SERVER_KEY` - Can override where to find the server's SSL key.
8181
* `SSL_CIPHERS` - Change the SSL ciphers support default only AES256+EECDH:AES256+EDH:!aNULL
8282
* `SSL_PROTOCOLS` - Change the SSL protocols supported default only TLSv1.2
83+
* `SSL_SESSION_TIMEOUT` - Specifies a time during which a client may reuse the session parameters (defaults to 10min)
8384
* `HTTP_LISTEN_PORT` - Change the default inside the container from 10080.
8485
* `HTTPS_LISTEN_PORT` - Change the default inside the container from 10443.
8586
* `HTTPS_REDIRECT` - Toggle whether or not we force redirects to HTTPS. Defaults to true.

defaults.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export SERVER_CERT=${SERVER_CERT:-/etc/keys/crt}
88
export SERVER_KEY=${SERVER_KEY:-/etc/keys/key}
99
export SSL_CIPHERS=${SSL_CIPHERS:-'AES256+EECDH:AES256+EDH:!aNULL'}
1010
export SSL_PROTOCOLS=${SSL_PROTOCOLS:-'TLSv1.2'}
11+
export SSL_SESSION_TIMEOUT=${SSL_SESSION_TIMEOUT:-'10m'}
1112
export HTTP_LISTEN_PORT=${HTTP_LISTEN_PORT:-10080}
1213
export HTTPS_LISTEN_PORT=${HTTPS_LISTEN_PORT:-10443}
1314
export HTTPS_REDIRECT=${HTTPS_REDIRECT:-'TRUE'}

go.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ cat > ${NGIX_CONF_DIR}/server_certs.conf <<-EOF_CERT_CONF
1616
ssl_ciphers ${SSL_CIPHERS};
1717
ssl_prefer_server_ciphers on;
1818
ssl_session_cache shared:SSL:10m;
19-
ssl_session_timeout 10m;
19+
ssl_session_timeout ${SSL_SESSION_TIMEOUT};
2020
ssl_stapling on;
2121
ssl_dhparam ${NGIX_CONF_DIR}/dhparam.pem;
2222
EOF_CERT_CONF

0 commit comments

Comments
 (0)