save function does save modules.json incorectly for jina-embeddings-v3

[guenthermi]

We noticed that when saving a jina-embeddings-v3 model as in the code example below the, the kwargs attribute is missing in modules.json of the saved model. When calling the encode function after loading a model, the task attribute is not passed to the the model anymore.

from sentence_transformers import SentenceTransformer

model = SentenceTransformer("jinaai/jina-embeddings-v3", trust_remote_code=True)
model.save('test_model')

[danielbichuetti]

There are issues with jinaai/jina-clip-v2 too. When you save and try to load again, custom_st is not found.

[tomaarsen]

@danielbichuetti I chased this down - there's 2 issues currently, one must be fixed in jina-clip-v2 itself (https://huggingface.co/jinaai/jina-clip-v2/discussions/17), and the other one I'll fix in #3112.
Thanks for mentioning!

• Tom Aarsen

[danielbichuetti]

@tomaarsen That's great! Thank you for the fast fix. That's amazing, as always.