Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow video files to be run through other models #27

Open
anishapai opened this issue Apr 28, 2021 · 0 comments
Open

Allow video files to be run through other models #27

anishapai opened this issue Apr 28, 2021 · 0 comments
Labels
enhancement New feature or request Predictions Relating to Predictions on Trained Models

Comments

@anishapai
Copy link
Contributor

anishapai commented Apr 28, 2021

We can modify the /predict endpoint so that when a video comes in, it is converted to audio and text as well, as per the user's request (this would involve thinking about the front-end UI first, and what is the most intuitive way to present options to the investigator before tackling the back-end). This issue deals with the front-end.

In the back-end, this would be done by adding a clause to the prediction pipeline that is something like:

if file type is video and audio models are selected:
  1. convert files to audio 
  2. run predictions on audio models.

Things to think about:

  • For step 2, the same create_new_prediction function can be called.
  • Would recommend abstracting this clause to a helper function because the create_new_prediction function for readability
  • There is a model_type parameter in the create_new_prediction function. Is this still necessary?
  • The user could select both video and audio models, so video prediction should still be run in that case.
@anishapai anishapai added good first issue Good for newcomers Predictions Relating to Predictions on Trained Models labels Apr 28, 2021
@anishapai anishapai changed the title Allow video files to be run through audio models Allow video files to be run through other models May 2, 2021
@anishapai anishapai added enhancement New feature or request and removed good first issue Good for newcomers labels May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Predictions Relating to Predictions on Trained Models
Projects
None yet
Development

No branches or pull requests

1 participant