Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add terrain mode for storymap. #4594

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

JinIgarashi
Copy link
Contributor

Thank you for submitting a pull request!

Description

removed maplibre-gl-sky plugin from storymap. it caused the issue when terrain is turned on

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Adding tests
  • Others ()

Verify the followings

  • Code is up-to-date with the develop branch
  • No build errors after pnpm build
  • No lint errors after pnpm lint
  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
  • Make sure all the existing features working well

Changesets

  • If your PR makes a change under packages folder that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Refer to CONTRIBUTING.MD for more information.

@JinIgarashi JinIgarashi added bug Something isn't working enhancement New feature or request labels Dec 2, 2024
@auto-assign auto-assign bot requested review from iferencik and Thuhaa December 2, 2024 05:20
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 1df6bbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@undp-data/svelte-maplibre-storymap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Design December 2, 2024 05:20 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Components December 2, 2024 05:20 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi merged commit 785c3fc into develop Dec 2, 2024
13 checks passed
@JinIgarashi JinIgarashi deleted the fix/4419-terrain-mode branch December 2, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] enable terrain mode in storymap editor for each chapter
1 participant