Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Add checks to the settings page #31

Open
MCMic opened this issue Jan 4, 2023 · 4 comments
Open

Add checks to the settings page #31

MCMic opened this issue Jan 4, 2023 · 4 comments

Comments

@MCMic
Copy link

MCMic commented Jan 4, 2023

The settings page gives instructions like redis needs to be used, pm.max_children needs to be high, it would be much more useful if it checked the current configuration and show a valid/invalid status instead.

For Redis, I’m pretty sure the application can check if it is configured and show a green/red message depending on the status?

For pm.max_children, it can show the current value for the setting, and maybe calculate how many users it can serve with the current setting.

For proxy buffering and timeout I do not know if this can be checked easily but if it is then it should be as well.

@provokateurin
Copy link
Contributor

At least timeout would be checkable by just connecting to it from the web interface and measuring the time until the connection is closed.
I guess proxy buffering introduces some latency to the requests, but I'm not sure if that is really testable since it could just be a slow internet connection or similar.

@p1gp1g
Copy link
Member

p1gp1g commented Apr 7, 2023

Version 1.6.1 of the android app (and 1.6.0 but it there are some bugs) do these checks :)

It checks:

  • If the keepalive is too low
  • If the request is buffered
  • If the connection timeout is too low compared to the keepalive

@provokateurin
Copy link
Contributor

Sounds good, but doing it on the server would also be nice.

@p1gp1g
Copy link
Member

p1gp1g commented Apr 7, 2023

I agree, but it is less urgent now :)

BTW, if someone wants to contribute, help is welcome

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants