Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difficulty changes map size #470

Closed
wants to merge 3 commits into from
Closed

Difficulty changes map size #470

wants to merge 3 commits into from

Conversation

IanP96
Copy link
Contributor

@IanP96 IanP96 commented Oct 13, 2024 •
edited
Loading

Description

  • Difficulty changes map size
    • 30 on easy, 40 on medium, 50 on hard
  • MapLoadConfig now stores default map settings
  • Unit test added

Closes #469

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • See "FINE" log output from MainGameLevelFactory (need to change logging.properties). The map size will be shown here. Map size will change with the difficulty.
  • Load a game. The map size will match the loaded game.
  • Unit test added

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

IanP96
IanP96 commented Oct 13, 2024
View reviewed changes
source/core/src/main/com/csse3200/game/areas/GameController.java
Comment on lines -112 to -122
/**
* Initialise this Game Area to use the provided levelFactory without loading a saved state.
*
* @param levelFactory the provided levelFactory.
* @param shouldLoad if the game should be loaded.
* @param player the main player entity.
*/
public GameController(GameArea gameArea, LevelFactory levelFactory, Entity player, Boolean shouldLoad) {
this(gameArea, levelFactory, player, false, new MapLoadConfig());
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was unused

@CameronBadman
Copy link
Contributor

you may wanna decrease those to like 10 - 30 max

@IanP96
Copy link
Contributor Author

IanP96 commented Oct 13, 2024

you may wanna decrease those to like 10 - 30 max

@CameronBadman now 10 on easy, 20 medium, 30 hard

dhruvanil55
dhruvanil55 reviewed Oct 14, 2024
View reviewed changes
source/core/src/main/com/csse3200/game/entities/configs/MapLoadConfig.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this implementation is not good it violates the way configs work and methods should be ion main game screen please do not change anything in config, contact me for more questions. I will have to close this .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvanil55 dhruvanil55 dhruvanil55 left review comments

@CameronBadman CameronBadman Awaiting requested review from CameronBadman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map size scales by difficulty
3 participants
@IanP96 @CameronBadman @dhruvanil55