Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clob getAll missing office filter in query #939

Closed
adamkorynta opened this issue Nov 1, 2024 · 0 comments
Closed

Clob getAll missing office filter in query #939

adamkorynta opened this issue Nov 1, 2024 · 0 comments
Assignees
@adamkorynta
Labels
approved-W192HQ23F0232-task4 Only valid if set by MikeNeilson, DanielO, CharlesG

Comments

@adamkorynta
Copy link
Collaborator

Peter and I noticed when checking for REGI specific clobs that more than the requested office was coming back in the payload. I started a PR, but it needs more work for regex checking and integration testing: #937
@MikeNeilson MikeNeilson added the approved-W192HQ23F0232-task4 Only valid if set by MikeNeilson, DanielO, CharlesG label Nov 5, 2024
@MikeNeilson MikeNeilson linked a pull request Nov 5, 2024 that will close this issue
add missing office where clause in Clob getAll query #937
Closed
@MikeNeilson MikeNeilson moved this from To triage to In progress in CWMS-Data-Api Maintanance Tracking Nov 5, 2024
@adamkorynta adamkorynta self-assigned this Nov 7, 2024
@adamkorynta adamkorynta moved this from In progress to In review in CWMS-Data-Api Maintanance Tracking Nov 7, 2024
@rma-rripken rma-rripken mentioned this issue Feb 13, 2025
Merged
MikeNeilson pushed a commit that referenced this issue Feb 18, 2025
@rma-rripken
Bugfix/939 clob getall office filter (#1024)
c224cc5 
I'm redoing pr #937 to address #939.  

develop had moved significantly since #937 had been started that it
seemed cleaner to just grab the handful of changes.

---------

Co-authored-by: ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamkorynta adamkorynta

Labels
approved-W192HQ23F0232-task4 Only valid if set by MikeNeilson, DanielO, CharlesG
Projects
CWMS-Data-Api Maintanance Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add missing office where clause in Clob getAll query USACE/cwms-data-api
3 participants
@MikeNeilson @adamkorynta @rma-rripken