Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all element_text with element_markdown for all si_style_* #31

Open
achafetz opened this issue Jul 1, 2021 · 2 comments
Open

Replace all element_text with element_markdown for all si_style_* #31

achafetz opened this issue Jul 1, 2021 · 2 comments
Assignees
@tessam30

Comments

@achafetz
Copy link
Contributor

achafetz commented Jul 1, 2021

good or bad idea?
@baboyma baboyma changed the title convert default theme to replace all element_text with element_markdown Replace all element_text with element_markdown for all si_style_* Jul 9, 2021
@tessam30
Copy link
Contributor

Holding off on this until we figure out how to get it out in AI. Perhaps we make it a default that can be toggled on and off with a T/F argument?

@baboyma
Copy link
Contributor

baboyma commented Aug 26, 2021

Looks like another duplicate with #26 and #39. I missed this before closing the other 2.

Suggestion: duplicate si_style() as si_markdown() and use the appropriate function in all the si_syle_*().

Note: It's still going to be a lot of ifelse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tessam30 tessam30

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@baboyma @tessam30 @achafetz