Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing values in the tk_params table foreign keys #1

Open
tomlue opened this issue Nov 9, 2023 · 4 comments
Open

Missing values in the tk_params table foreign keys #1

tomlue opened this issue Nov 9, 2023 · 4 comments

Comments

@tomlue
Copy link

tomlue commented Nov 9, 2023

image

Other fields are also missing like preferred_name in the chemicals table and title in the documents table.

@sayrerr
Copy link
Collaborator

sayrerr commented Nov 13, 2023

hi @tomlue i hope you're well! the purpose of the cvtdb is not to store bibliographic or chemical information, so the docs and chems table are intended to have the minimum uniquely identifying information to link to more definitive sources. in the tk_params table, a tk_param may be calculated on either a series, study, or chemical basis, so what you're showing me looks as-intended. let me know if i haven't completely explained it! thanks for your interest

@tomlue
Copy link
Author

tomlue commented Nov 14, 2023

Hi Sayrerr,
That makes sense, but in the sqlite database distributed here, the table for tk_params doesn't have any keys in the fk_chemical_id or fk_study_id columns. You do have tables for chemicals and studies and it seems like this is meant to be linked, but currently it is empty (see screenshot).

@sayrerr
Copy link
Collaborator

sayrerr commented Nov 14, 2023

All the values shown were calculated on a per-series basis while we wait on updates to invivopkfit. We expanded the data model because we intend to have params calculated on a per-chemical and per-study basis as soon as possible. I think that manuscript is almost written

@tomlue
Copy link
Author

tomlue commented Nov 14, 2023

Ok, I understand and I think that is how we handled it here https://insilica.co/posts/2023-11-09-cvtdb. I can wait until the update, thank you for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants