Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nmed_gtbl_neg/_pos calculation in tcplFit2() when number of replicates is not consistent #339

Open
cthunes opened this issue Feb 27, 2025 · 0 comments · May be fixed by #340
Open

Fix nmed_gtbl_neg/_pos calculation in tcplFit2() when number of replicates is not consistent #339

cthunes opened this issue Feb 27, 2025 · 0 comments · May be fixed by #340
Assignees
@cthunes
Labels
bug

Comments

@cthunes
Copy link
Contributor

cthunes commented Feb 27, 2025 •
edited
Loading

Based on https://github.com/USEPA/ToxCast-Internal/issues/127 issue brought by @Kelly-Carstens-EPA

Replace https://github.com/USEPA/CompTox-ToxCast-tcpl/blob/dev/R/tcplFit2.R#L32
nmed_gtbl_neg = sum(med_rmds_neg) / first(nconcs)
with something like
nmed_gtbl_neg = sum(med_rmds_neg) / mean(unique(nconcs[res$med_rmds_neg]))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthunes cthunes

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated nmed_gtbl_neg and _pos to use length of unique concs with TRUE USEPA/CompTox-ToxCast-tcpl
1 participant
@cthunes