updated nmed_gtbl_neg and _pos to use length of unique concs with TRUE #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthunes
requested review from
brown-jason,
Kelly-Carstens-EPA and
madison-feshuk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution should work to resolve the issue with nmed_gtbl_neg and _pos and consequently fix the issue @Kelly-Carstens-EPA spotted with flagging "active with only highest conc above baseline" and other flags that may use this . Closes #339. Aeid 2940 mc4 column nmed_gtbl_neg before and after update:
You can see the very bottom one in each picture is the row with example from https://github.com/USEPA/ToxCast-Internal/issues/127 . Before the issue was it was rounded down to 1 when it should have been 2.