redefined top as max absolute resp across conc range #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented changes with how top is defined in tcplfit2_core functionality. I did not change anything in tcplhit2_core functionality including the hitcalling process. Hitcalling changes will be made in a separate PR.
I redefined top as detailed in the ticket. However, I am finding this top value graphically for all the methods except gain-loss which already uses the derivative and sets it equal to 0 to find the model top. Because of this method, I implemented a pseudo-value transformation for untreated control groups (conc = 0) so that conc_seq can successfully generate points along the range.
I have a generated html tester file available upon request.