Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toplikelihood reparameterization for biphasic poly2 #90

Open
madison-feshuk opened this issue Jun 10, 2024 · 0 comments
Open

toplikelihood reparameterization for biphasic poly2 #90

madison-feshuk opened this issue Jun 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@madison-feshuk
Copy link
Collaborator

The poly2 biphasic model update #69 did not adjust the continuous hit calling P3 calculation as seen in #89. Currently the probability of top being above cutoff assumes top occurs at max concentration, which is not always the case: https://github.com/USEPA/CompTox-ToxCast-tcplFit2/blob/master/R/toplikelihood.R#L53

Ex: Fits with poly2 update look better, but this should be a hit. Indicates reparameterization may be needed.
image

@madison-feshuk madison-feshuk added the bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants