Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing sources from renewables #278

Open
dt-woods opened this issue Jan 15, 2025 · 2 comments
Open

Add missing sources from renewables #278

dt-woods opened this issue Jan 15, 2025 · 2 comments
Labels
in v2 Issues marked for inclusion in version 2

Comments

@dt-woods
Copy link
Collaborator

In the 2022 results inventory, there is no geothermal. This was identified in the second commit in KeyLogicLCA#14 (KeyLogicLCA@950f098); however, the cause of the error was traced back to the renewable module, geothermal.py, which doesn't have the new source string (as was done for hydro, nuclear, solar PV, solar thermal, and wind; see fix_renewable method in solar_upstream.py). Consider adding a source string for this inventory and see whether it fixes the missing inventory problem.

@dt-woods
Copy link
Collaborator Author

Looking at the latest GREET model, their 2024 U.S. mix has 0% geothermal, what little of it comes from California and Nevada. Maybe there just isn't enough to make the threshold for eLCI reporting.

@dt-woods
Copy link
Collaborator Author

This seems to go in hand with #247, as GEOTHERMAL is not excluded from the efficiency filter; see

fuel_categories_to_exclude=["NUCLEAR","WIND","SOLAR","SOLARTHERMAL",

If it is added to the exclusion list, GEOTHERMAL returns to the results (see orange bars where GEOTHERMAL is added to the exclusion list).

Image

dt-woods added a commit to KeyLogicLCA/ElectricityLCI that referenced this issue Jan 22, 2025
The 2022 geothermal facilities were lost due to the efficiency filter. Geothermal added to the exclusion list in eia923_generation.py.
@dt-woods dt-woods added the in v2 Issues marked for inclusion in version 2 label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in v2 Issues marked for inclusion in version 2
Projects
None yet
Development

No branches or pull requests

1 participant