Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand unit test coverage and expand regression testing #162

Open
cbuahin opened this issue Feb 12, 2024 · 2 comments
Open

Expand unit test coverage and expand regression testing #162

cbuahin opened this issue Feb 12, 2024 · 2 comments
Assignees
Milestone

Comments

@cbuahin
Copy link
Collaborator

cbuahin commented Feb 12, 2024

Set up performance benchmarking and expand unit test coverage for critical portions of the SWMM code. The following areas will be targeted initially for expanding the unit tests:

  • SWMM output library (test exists but could be expanded)
  • Hotstart file saving and reading
  • SWMM API
  • SWMM cross-sectional shapes
  • Dual drainage implementation
@cbuahin cbuahin self-assigned this Feb 12, 2024
@dickinsonre
Copy link

By dual drainage you mean the streets and inlets from SWMM 5.2?

@cbuahin
Copy link
Collaborator Author

cbuahin commented Feb 12, 2024

Yes, Robert. It is relatively new and perhaps not as mature as the other portions of the code. Testing it more rigorously will help assure its accuracy going forward.

cbuahin added a commit that referenced this issue Feb 15, 2024
cbuahin added a commit that referenced this issue Feb 15, 2024
cbuahin added a commit that referenced this issue Feb 15, 2024
cbuahin added a commit that referenced this issue Feb 15, 2024
cbuahin added a commit that referenced this issue Feb 15, 2024
cbuahin added a commit that referenced this issue Feb 22, 2024
@cbuahin cbuahin added this to the v5.3.0 milestone May 29, 2024
cbuahin added a commit that referenced this issue Jun 13, 2024
cbuahin added a commit that referenced this issue Jun 13, 2024
@cbuahin cbuahin changed the title Expand Unit Test Coverage Expand unit test coverage and expand regression testing Jul 15, 2024
cbuahin added a commit that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants