Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage button clicks and input on Censored Data tab as the method is applied or undone #158

Closed
3 tasks
cristinamullin opened this issue Jun 6, 2024 · 3 comments · Fixed by #191
Closed
3 tasks

Manage button clicks and input on Censored Data tab as the method is applied or undone #158

cristinamullin opened this issue Jun 6, 2024 · 3 comments · Fixed by #191
Assignees
@JamesBisese
Labels
bug Something isn't working

Comments

@cristinamullin
Copy link
Collaborator

Describe the bug

If a user clicks "Apply Methods to Dataset" more than once... the method is applied over and over.

For example,
Non-Detect Handling Method = Multiply detection limit by x
Multiplier (x) = 0.5
Over-Detect Handling Method = No change
then each time the sum reduction = ½ * ½ * ½.

Also, multiple different methods can be applied now which does not make sense. A user must only select one, and then undo the method if they want to select and apply a different one after reviewing the table.

To Reproduce

Use any dataset and go to the censored data tab, click the "Apply Methods to Dataset" button more than once and observe.

Expected behavior

The "Apply Methods to Dataset" button should only be able to be clicked once. After that, the button should disappear or maybe turn grey. If a user wants to undo the method they can click the "Undo Method Application" button. If they click that, they the "Apply Methods to Dataset" should be made available again.

Screenshots

image

Reminders for TADA contributors addressing this issue

New features should include all of the following work:

  • Create the function/code.

  • Document all code using comments to describe what is does.

  • Create tests.
@cristinamullin cristinamullin added the bug Something isn't working label Jun 6, 2024
@cristinamullin cristinamullin mentioned this issue Jun 6, 2024
Closed
@JamesBisese
Copy link
Collaborator

JamesBisese commented Dec 4, 2024 •
edited
Loading

This ticket will take 3-4 hours. I need to deal with these issues

  1. signaling the observable to re-enable when new data is loaded using any one of 3 paths (WQP, Upload dataset, upload Progress File)
  2. Disable the 'nd_mult' and 'od_mult' fields - so it can't be changed once they have been run once.
  3. Disable the 'Undo' button if there has been no Censor run.
  4. Enable the Undo button after the Censor has been run

branch: Manage-input-on-Censore-tab-#158

@JamesBisese JamesBisese changed the title Censored Data tab bug Manage button clicks and input on Censored Data tab as the method is applied or undone Dec 4, 2024
@JamesBisese
Copy link
Collaborator

JamesBisese commented Dec 4, 2024 •
edited
Loading

This took less time than I thought. Here is the behavior now

  1. if user hits the "Apply Methods to Dataset" button the other Censor buttons and UI elements are disabled
  2. if the user hits the Undo Methods the UI elements are enabled.

image

and after hitting Apply ...

image

Then after hitting "Undo Method Application"

image

I ran the process repeatedly and the numbers on the example first-10-rows seems to stay the same.

@JamesBisese
Copy link
Collaborator

JamesBisese commented Dec 4, 2024 •
edited
Loading

Note: need to find a dataset with Over-Detects in order to test the Over-Detect handling. I am using Utah 15k example data and there are no over detects. Shepardstown has 1 over-detect, although there are 1809 rows flagged "Result value(s) above the national threshold for a given characteristic, possibly indicating non-sensical value(s) (see TADA.ResultValueAboveUpperThreshold.Flag)"

JamesBisese added a commit that referenced this issue Dec 5, 2024
@JamesBisese
Merge branch 'develop' into Manage-input-on-Censor-tab-#158
73a85df
cristinamullin added a commit that referenced this issue Dec 5, 2024
@cristinamullin
Merge branch 'develop' into Manage-input-on-Censor-tab-#158
7c485d9
@cristinamullin cristinamullin linked a pull request Dec 5, 2024 that will close this issue
Manage input on censor tab #158 #191
Merged
cristinamullin added a commit that referenced this issue Dec 5, 2024
@cristinamullin
Merge pull request #191 from USEPA/Manage-input-on-Censor-tab-#158
7577801 
Manage input on censor tab #158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesBisese JamesBisese

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Manage input on censor tab #158 USEPA/TADAShiny
2 participants
@JamesBisese @cristinamullin