Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagging table does not respond to switches properly #62

Open
elisehinman opened this issue Jun 17, 2023 · 2 comments
Open

Flagging table does not respond to switches properly #62

elisehinman opened this issue Jun 17, 2023 · 2 comments

Comments

@elisehinman
Copy link
Contributor

elisehinman commented Jun 17, 2023

Describe the bug
I went through the shiny app with one dataset, and then went to the first page to try another dataset in the same session. The second dataset loaded fine into the app, and the flagging table loaded fine, but the switches no longer changed the summary removed/retained when turned on/off, and I believe was no longer affecting the tadat$removals or some other reactive object. I am wondering if this is due to the unpredictable behavior of observes within observers, which occurs in the observeEvent function in the flagging module.

To Reproduce
Steps to reproduce the behavior:

  1. Load one test dataset, and run flagging functions
  2. Load second test dataset, re-run flagging functions
  3. Switch on an off switch with results affected and look at summary table

Expected behavior
The flagging table should be responsive to multiple datasets in one session.

@elisehinman
Copy link
Contributor Author

@cristinamullin Because of this issue, please advise users to reload the shiny app when starting with a new dataset.

@cristinamullin
Copy link
Collaborator

I think it is fine to address this issue by simply adding a warning or text on the import tab to tell users that they must reload the shiny app before starting to work with a new dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants