Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

Calculate 'timeInterval' instead of setting it as input #22

Open
limnoliver opened this issue Jul 25, 2017 · 3 comments
Open

Calculate 'timeInterval' instead of setting it as input #22

limnoliver opened this issue Jul 25, 2017 · 3 comments
Assignees

Comments

@limnoliver
Copy link
Member

limnoliver commented Jul 25, 2017

timeInterval is the minimum time expected between tips. This can be variable by rain gauge, and so may be more practical to calculate something like min(diff.time(pdate[i], pdate[i-1])) and use it as input to functions.

Currently implemented in RMevents_sko -- use elsewhere where timeInterval is needed.

@limnoliver limnoliver self-assigned this Jan 9, 2018
@limnoliver
Copy link
Member Author

In erosivity function, we need to internally calculate timeInterval, but we don't have the original (raw) data to calculate df(time). Export df(time) somehow from RMevents.

@limnoliver
Copy link
Member Author

This is now an output of RMevents -- still deciding if this should still be an argument in the function where the user can subset the list from RMevents or just use behind the scenes.

@rbcarvin
Copy link
Contributor

rbcarvin commented Mar 8, 2018

This can be behind the scenes, if the user changed it to something other than the minimum time then rainmaker will be giving them a less correct answer. In the past, the program 'trusted' the user to know this value, much better to just figure it out for the user.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants