Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

RMevents_sample can't handle a little rain #49

Open
rbcarvin opened this issue Jul 12, 2018 · 2 comments
Open

RMevents_sample can't handle a little rain #49

rbcarvin opened this issue Jul 12, 2018 · 2 comments

Comments

@rbcarvin
Copy link
Contributor

When a rain file has very small rain values (<0.000) RMevents_sample counts it in the rain event and doesn't start counting its interevent period. No rain gage equipment can measure rain amounts that small, rain files with values that small have some other sort of problem. Nonetheless, we could prevent the problem by having RMevents_sample round the rain values to 3 decimals before the ieHr step.
This did the trick in a script prior to running RMevents_sample:

#round rain data to omit rows with very small rain values
precip$rain <- round(precip$rain, digits = 3)

@srcorsi-USGS
Copy link
Contributor

This issue has to do with the quality of data in the input file. My preference would be to leave it to the user to check data quality before using it in Rainmaker rather than having a fix for bad data within the script.

@rbcarvin
Copy link
Contributor Author

rbcarvin commented Jul 22, 2018

For this and other data fixes users keep running into - perhaps an enhancement would be a data scrubbing function/workflow to test and ensure data are ready for the 'real' rainmaker, as opposed to writing steps within rainmaker functions to catch these edge cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants