Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify full pipeline to projected crs #17

Open
msleckman opened this issue Jul 23, 2022 · 1 comment
Open

Modify full pipeline to projected crs #17

msleckman opened this issue Jul 23, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request learn more request to dive deeper and explore process or feature

Comments

@msleckman
Copy link
Collaborator

msleckman commented Jul 23, 2022

Projection issue

[Disclaimer: The following comment comes from someone who is not a geographer. Someone with more insight into the topic is encouraged to add/correct any inaccuracies or oversights]... but, we should maybe touch on projections a little bit. Everything now is now being projected to the specified_crs of EPSG: 4326, which is essentially unprojected and, especially if we turn off spherical geometry (see comment on line 15 of 2_process/src/scope_lake_tributaries.R, potentially going to lead to some inaccuracy. What makes this tricky is that leaflet requires things to be in EPSG 4326, from what I can tell. So, if we are going to send them shapefiles or use any of our products for analysis or measurement at all, I suggest that we make sure that we project the data into a different coordinate system, like EPSG 5070 and we can just project it back to 4326 just for plotting in leaflet.

Originally posted by @amart90 in #16 (review)

To do:

  • Initiate new PR and modify all spatial files in pipeline to new projected crs.
@msleckman msleckman assigned msleckman and amart90 and unassigned msleckman Jul 23, 2022
@msleckman
Copy link
Collaborator Author

msleckman commented Dec 20, 2022

Not sure if this is still immediately relevant. 4326 seems to work for our purposes.
items to come back to after addressing feedback.

labeling as a learn more and 'enhacement` issue because do not think this change will impact our output.

@msleckman msleckman added enhancement New feature or request learn more request to dive deeper and explore process or feature labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request learn more request to dive deeper and explore process or feature
Projects
None yet
Development

No branches or pull requests

2 participants