Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include commented out Google Analytics Key Placeholder in build #89

Open
HansVraga opened this issue Feb 2, 2016 · 5 comments
Open
Milestone

Comments

@HansVraga
Copy link
Member

Include the option of adding the site-specific Google Analytics key when generating a new application.

@marsmith
Copy link
Collaborator

marsmith commented Feb 3, 2016

I thought about this more, I think we could put in a key to the generator like "xxxxxx-xx" and then the dev just hot swap that out when the app is on a server and the app is set up on google analytics. ie. Don't put an actual tracking code in at app -generation

@njestes
Copy link
Contributor

njestes commented Feb 4, 2016

And I think we should keep that block commented out to avoid hitting GA with a good for nothing tracking code, and then that leaves it to the dev to uncomment it and add a valid code once an app is ready to deploy with a valid URL.

I'm thinking I'll add a "warning" to "gulp build" command output that checks for a GA code and lets the dev know that they may want to set that up if the app is ready for a server.

@HansVraga HansVraga changed the title Include Google Analytics Key in Build Include commented out Google Analytics Key Placeholder in build Mar 2, 2017
@HansVraga
Copy link
Member Author

Updated Title according to above suggestions.

@marsmith
Copy link
Collaborator

marsmith commented Mar 8, 2017

I like nicks idea here, we can search for this in gulp

@marsmith marsmith added this to the v2.01 milestone Mar 8, 2017
@HansVraga HansVraga modified the milestones: v2.01, v2.0.0 Jun 14, 2017
@HansVraga
Copy link
Member Author

brief chat with @lprivette - we're going to put GA placeholders in for key functions we want tracked events for, and hook into a variable in the config file that would hold the GA key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants