Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Something funky happening with EventManager.ts on transpilation #66

Open
BlakeDraper opened this issue Apr 27, 2016 · 2 comments
Open
Assignees
Labels

Comments

@BlakeDraper
Copy link
Contributor

I noticed that in some cases, the typescript transpiler is changing this:
(function (event) { to this: (function (Event_1) {

which also makes this line go from this:
this._eventList[EventName] = new Event(new event.Delegate());
to this:this._eventList[EventName] = new Event(new Event_1.Delegate());

and finally this: if (args === void 0) { args = event.EventArgs.Empty; }
to this: if (args === void 0) { args = Event_1.EventArgs.Empty; }

Not sure where this Event_1 business is coming from, but should look into it. I nominate @jknewson.

@marsmith
Copy link
Collaborator

@BlakeDraper does this happen in the visual studio transpile?

@BlakeDraper
Copy link
Contributor Author

@marsmith I got it from a pull after you had committed, so yes, it seems that it does. But maybe test to confirm. May work on building the TS transpilation into a gulp task soon so its at least consistent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants