Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize Winery Feature #210

Open
salmma opened this issue Feb 11, 2022 · 2 comments
Open

Finalize Winery Feature #210

salmma opened this issue Feb 11, 2022 · 2 comments
Assignees
@PhilWun @mar-be
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@salmma
Copy link
Contributor

salmma commented Feb 11, 2022 •
edited
Loading

  • we require tests (similar to tests of other classes, with mocked winery) for the new feature in the QC-Atlas
  • union with UI
  • we require (UI) documentation about the feature in our readthedocs
  • quantil-docker update for winery and env variables, additional profile for winery
@salmma salmma added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 11, 2022
@mar-be
Copy link
Contributor

mar-be commented Feb 14, 2022

UST-QuAntiL/quantil-docker#30 adds Winery to quantil-docker

@mar-be
Copy link
Contributor

mar-be commented Feb 23, 2022

#213 adds tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilWun PhilWun

@mar-be mar-be

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PhilWun @salmma @mar-be