Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples for v2 #167

Closed
lcgraham opened this issue Mar 22, 2016 · 16 comments
Closed

Update examples for v2 #167

lcgraham opened this issue Mar 22, 2016 · 16 comments

Comments

@lcgraham
Copy link
Contributor

No description provided.

@lcgraham
Copy link
Contributor Author

Update to use logging see logging from multiple modules
All print statements within the source have been changed to appropriate logging commands

See #192

@lcgraham
Copy link
Contributor Author

Currently, validationExample, nonlinearMap, linearMap, contaminantTransport, and FEniCS examples are up to date. @scottw13 are the sensitivity examples up to date?

None of the examples use logging.

@scottw13
Copy link
Contributor

They are not... they need some attention. I should be able to get them in
good shape sometime next week.

Scott

On Tue, May 24, 2016 at 1:27 PM, Lindley Graham [email protected]
wrote:

Currently, validationExample, nonlinearMap, linearMap,
contaminantTransport, and FEniCS examples are up to date. @scottw13
https://github.com/scottw13 are the sensitivity examples up to date?

None of the examples use logging.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#167 (comment)

@scottw13
Copy link
Contributor

In sample.py the method check_num() checks that

input_set._jacobian.shape[0] == input_set.shape._values.shape[0]

But in my examples I do not have the jacobians at every samples, so
_jacobians does NOT have the same length as _values.

How should we fix this? Maybe jacobians shouldn't be checked here. Maybe
I should make _jacobians have the same shape[0] as _values, but fill
entries that I dont have jacobians for with Nones? (Not sure I like that
option) I am just trying to solve the inverse problem after finding the
optimal set of QoIs, I don't even need the jacobians for this but I get
this error when I try to set my_discretization before I solve the inverse
problem,

I guess for now I will just set _jocobians to None at this step since I
don't need them anymore, but that probably isn't the best long term
solution.

Scott

On Tue, May 24, 2016 at 3:55 PM, Scott Walsh [email protected] wrote:

They are not... they need some attention. I should be able to get them
in good shape sometime next week.

Scott

On Tue, May 24, 2016 at 1:27 PM, Lindley Graham [email protected]
wrote:

Currently, validationExample, nonlinearMap, linearMap,
contaminantTransport, and FEniCS examples are up to date. @scottw13
https://github.com/scottw13 are the sensitivity examples up to date?

None of the examples use logging.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#167 (comment)

@lcgraham
Copy link
Contributor Author

If I remember correctly you only have Jacobians at the center of point clusters. What about returning a sample set that only has the values for centers since you create and need the Jacobians at all the centers? Or if a full sample set is not needed and only the indices of the optimal QoI then how about returning just the indices?

On May 29, 2016, at 7:58 PM, Scott Walsh [email protected] wrote:

In sample.py the method check_num() checks that

input_set._jacobian.shape[0] == input_set.shape._values.shape[0]

But in my examples I do not have the jacobians at every samples, so
_jacobians does NOT have the same length as _values.

How should we fix this? Maybe jacobians shouldn't be checked here. Maybe
I should make _jacobians have the same shape[0] as _values, but fill
entries that I dont have jacobians for with Nones? (Not sure I like that
option) I am just trying to solve the inverse problem after finding the
optimal set of QoIs, I don't even need the jacobians for this but I get
this error when I try to set my_discretization before I solve the inverse
problem,

I guess for now I will just set _jocobians to None at this step since I
don't need them anymore, but that probably isn't the best long term
solution.

Scott

On Tue, May 24, 2016 at 3:55 PM, Scott Walsh [email protected] wrote:

They are not... they need some attention. I should be able to get them
in good shape sometime next week.

Scott

On Tue, May 24, 2016 at 1:27 PM, Lindley Graham [email protected]
wrote:

Currently, validationExample, nonlinearMap, linearMap,
contaminantTransport, and FEniCS examples are up to date. @scottw13
https://github.com/scottw13 are the sensitivity examples up to date?

None of the examples use logging.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#167 (comment)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@lcgraham
Copy link
Contributor Author

Apparently examples are no longer up to date and need to be rechecked.

@lcgraham
Copy link
Contributor Author

@eecsu can you submit a pull-request with the examples that you've updated? If I recall correctly you've made significant changes which haven't been pulled in yet.

@lcgraham
Copy link
Contributor Author

lcgraham commented Jun 21, 2016

Note that recent pull-requests have affected examples.

@eecsu
Copy link
Contributor

eecsu commented Jun 21, 2016

Yeah, I am working with Pilosov on these. He is getting the hang of BET
now. I have some other things to do with the FEniCS example in order to use
launcher, and also do the KL stuff just once. Should have some time to
clean this all up in the next two days. Will also get to your pull request
soon.

On Tue, Jun 21, 2016 at 1:46 PM, Lindley Graham [email protected]
wrote:

Note that recent pull-requests have updated examples.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#167 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AEwKZR92zZeagos9i_-UJZIDnr_PifSVks5qOD94gaJpZM4H2mBx
.

@lcgraham
Copy link
Contributor Author

Sounds great. Thanks for the update!

On Jun 21, 2016, at 3:59 PM, Troy Butler [email protected] wrote:

Yeah, I am working with Pilosov on these. He is getting the hang of BET
now. I have some other things to do with the FEniCS example in order to use
launcher, and also do the KL stuff just once. Should have some time to
clean this all up in the next two days. Will also get to your pull request
soon.

On Tue, Jun 21, 2016 at 1:46 PM, Lindley Graham [email protected]
wrote:

Note that recent pull-requests have updated examples.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#167 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AEwKZR92zZeagos9i_-UJZIDnr_PifSVks5qOD94gaJpZM4H2mBx
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@lcgraham
Copy link
Contributor Author

@eecsu, @mpilosov when this is done feel free to close the issue.

@eecsu
Copy link
Contributor

eecsu commented Jun 25, 2016

I have updated the documentation for the linear, nonlinear, validation, and both FEniCS examples.

For the examples others wrote, they may want to update in a similar style that breaks down according to steps like how I did it.

On the gh-pages, if you access an example through the "List of all examples" on the side panel, then this creates a table of contents for easy navigation through the steps.

@lcgraham
Copy link
Contributor Author

This task include updating the *.rst files. I need to update these for some of the examples I have written. @smattis can you check the associated *.rst files for the contaminant transport example?

@eecsu
Copy link
Contributor

eecsu commented Jun 30, 2016

@lcgraham did you look over the changes to the ADCIRC from file documentation that I changed? I tried to make at least the first set of examples consistent with the format of outlining the steps we are doing in the basic algorithm of solving a stochastic inverse problem. The examples themselves were updated slightly with visualization of domains showing up in the first set of scripts (which allowed me to remove the documentation that just focused on the documentation since it was basically absorbed into these files).

@scottw13 still needs to provide documentation for the sensitivity examples. I can probably take a first stab at it and have him look it over to make sure I am understanding everything correctly. Probably a good exercise for me to go through his examples more carefully anyway.

@scottw13
Copy link
Contributor

Troy if you want to take a first stab at these that's fine by me. Let me
know how it goes or if you have any questions.

Scott

On Thu, Jun 30, 2016 at 10:58 AM, Troy Butler [email protected]
wrote:

@lcgraham https://github.com/lcgraham did you look over the changes to
the ADCIRC from file documentation that I changed? I tried to make at least
the first set of examples consistent with the format of outlining the steps
we are doing in the basic algorithm of solving a stochastic inverse
problem. The examples themselves were updated slightly with visualization
of domains showing up in the first set of scripts (which allowed me to
remove the documentation that just focused on the documentation since it
was basically absorbed into these files).

@scottw13 https://github.com/scottw13 still needs to provide
documentation for the sensitivity examples. I can probably take a first
stab at it and have him look it over to make sure I am understanding
everything correctly. Probably a good exercise for me to go through his
examples more carefully anyway.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#167 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AFMm2toD9uUxxSy_hqFg5EH4BncQXxRxks5qQ_XBgaJpZM4H2mBx
.

@lcgraham
Copy link
Contributor Author

@eecsu I really like what you did with teh first set of ADCIRC examples. So
much so that I want to copy your lead for the second set of ADCIRC examples
(the Q_*.py ones).

On Thu, Jun 30, 2016 at 1:00 PM Scott Walsh [email protected]
wrote:

Troy if you want to take a first stab at these that's fine by me. Let me
know how it goes or if you have any questions.

Scott

On Thu, Jun 30, 2016 at 10:58 AM, Troy Butler [email protected]
wrote:

@lcgraham https://github.com/lcgraham did you look over the changes to
the ADCIRC from file documentation that I changed? I tried to make at
least
the first set of examples consistent with the format of outlining the
steps
we are doing in the basic algorithm of solving a stochastic inverse
problem. The examples themselves were updated slightly with visualization
of domains showing up in the first set of scripts (which allowed me to
remove the documentation that just focused on the documentation since it
was basically absorbed into these files).

@scottw13 https://github.com/scottw13 still needs to provide
documentation for the sensitivity examples. I can probably take a first
stab at it and have him look it over to make sure I am understanding
everything correctly. Probably a good exercise for me to go through his
examples more carefully anyway.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#167 (comment), or
mute
the thread
<
https://github.com/notifications/unsubscribe/AFMm2toD9uUxxSy_hqFg5EH4BncQXxRxks5qQ_XBgaJpZM4H2mBx

.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#167 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AC3o7Y5hULo2_ek61xlpZGATQXugvSRQks5qQ_ZEgaJpZM4H2mBx
.

Lindley Graham, Ph.D. 2015

@lcgraham lcgraham closed this as completed Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants