Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate GraphQL API to different branch #212

Closed
2 tasks
jpahm opened this issue Sep 5, 2024 · 3 comments
Closed
2 tasks

Relocate GraphQL API to different branch #212

jpahm opened this issue Sep 5, 2024 · 3 comments
Assignees
Labels
L1 A task suitable for someone who is comfortable helping with basic issues.

Comments

@jpahm
Copy link
Contributor

jpahm commented Sep 5, 2024

Currently, the dev branch has a graphql directory containing a (somewhat outdated now) GraphQL-based implementation of the API. While this could be useful to transition to at a later point, using GraphQL is not currently a priority nor is it a clean change to make.

As such, it would make sense to move this directory to its own separate branch and then remove it from the dev branch.

  • Remove graphql directory from dev branch
  • Transition graphql directory to its own branch
@jpahm jpahm added the L1 A task suitable for someone who is comfortable helping with basic issues. label Sep 5, 2024
@mikehquan19
Copy link
Contributor

Hi! I'd like to work on this but I have a few questions to clarify. Are we supposed to create another branch which we will keep the graphql directory and then we will remove graphql in the branch develop?

Thanks.

@jpahm
Copy link
Contributor Author

jpahm commented Sep 20, 2024

Hi! I'd like to work on this but I have a few questions to clarify. Are we supposed to create another branch which we will keep the graphql directory and then we will remove graphql in the branch develop?

Thanks.

Hi, yes, that's correct! You can go ahead and merge the GraphQL branch you make into this branch. Ideally, the GraphQL branch should exclude the current API (in the api dir) and the non-GraphQL branch should exclude the GraphQL API (in the graphql dir).

@jpahm
Copy link
Contributor Author

jpahm commented Sep 21, 2024

Finished via #220 and #221.

@jpahm jpahm closed this as completed Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L1 A task suitable for someone who is comfortable helping with basic issues.
Projects
None yet
Development

No branches or pull requests

2 participants