Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients Should Be Able To Subscribe to Socket Messages #3

Open
Olliebrown opened this issue Jun 20, 2022 · 0 comments
Open

Clients Should Be Able To Subscribe to Socket Messages #3

Olliebrown opened this issue Jun 20, 2022 · 0 comments
Labels
enhancement New feature or request sockets Involves socket.io communication

Comments

@Olliebrown
Copy link
Member

While the socket.io message system needs to be able to send any events that the EDSDK might have as messages, a connected client should only receive messages it has explicitly opted in to. This can be achieved by having 'subscription' routes as part of the normal REST API.

Thoughts on implementation:

  • Socket.io already has a mechanism for grouping clients and servers into rooms that we can use to implement this.
  • There should be a route for subscribing to a message of some type and a route for unsubscribing
  • One subscription route with a path parameter for the message type should suffice (and a similar unsubscribe route)
@Olliebrown Olliebrown added enhancement New feature or request sockets Involves socket.io communication labels Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sockets Involves socket.io communication
Projects
None yet
Development

No branches or pull requests

1 participant