Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Managing Theme Switching #205

Open
senigius opened this issue Feb 19, 2024 · 2 comments
Open

Issue with Managing Theme Switching #205

senigius opened this issue Feb 19, 2024 · 2 comments

Comments

@senigius
Copy link

I am currently using the storybook-design-token package version 3.0.0 in my project. I am trying to handle theme switching using the @etchteam/[email protected] package. I have two CSS variable files: default-light.css and default-dark.css. Currently, both files are being pulled in using the DESIGNTOKENGLOB variable, but I would like to only load one file based on the selected theme.

I have not tried other versions of storybook-design-token, so I am unsure if reverting to an earlier version would solve this issue. In previous versions, there was a mechanism with the 'files':

const tokenContext = require.context(
  '!!raw-loader!../src',
  true,
  /.\.(css|less|scss|svg)$/
);

const tokenFiles = tokenContext.keys().map(function (filename) {
  return { filename: filename, content: tokenContext(filename).default };
});

export const parameters = {
  designToken: {
    defaultTab: 'Colors',
    files: tokenFiles
  }
};

I would appreciate any guidance or suggestions on how to handle this situation in version 3.0.0. Thank you for your help.

@senigius
Copy link
Author

Screen.Recording.2024-02-19.at.15.33.18-1.mov

@JamesIves
Copy link

JamesIves commented Feb 22, 2024

I'm also experiencing odd behavior when used in conjunction with this addon. I think an ideal state for me would be anytime a theme is switched, the list of tokens are updated and reflected with what is currently loaded as opposed to building a list of both.

I filed a separate issue in #207 which may be caused by a similar thing as the storybook-design-token addon doesn't seem to update values after they are initially set, which seems to be what is happening here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants