Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Variables to refactor #1

Open
andrespias opened this issue Jan 23, 2020 · 2 comments
Open

[FEATURE] Variables to refactor #1

andrespias opened this issue Jan 23, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@andrespias
Copy link
Member

andrespias commented Jan 23, 2020

The names of the role variables could be confused with the backuppc_server role. Also, is missing the prefix backuppc_ in backup_state and include_files

@andrespias andrespias added the enhancement New feature or request label Jan 23, 2020
@ulvida
Copy link
Member

ulvida commented Feb 9, 2020

Indeed. However, the refactor of variables will lead to a change of the major version of the role.

Moreover the names, let's also analyse the whole role to see if it can be improved.

Particularly, we should take into consideration the problem raised in PR when addressing the issue #2.

@ulvida
Copy link
Member

ulvida commented Jun 8, 2020

Also, is missing the prefix backuppc_ in backup_state and include_files

This is addressed in v2.0.0.
However, I missed the problem of possible variables duplication with role backuppc_server. We should address this when refactoring this role. I put an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants