Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases part is cached #6

Open
friday opened this issue Aug 20, 2021 · 5 comments
Open

Releases part is cached #6

friday opened this issue Aug 20, 2021 · 5 comments
Assignees

Comments

@friday
Copy link
Member

friday commented Aug 20, 2021

This is how the releases show up for me in Chrome:

uncognito

Incognito window:
incognito

@friday
Copy link
Member Author

friday commented Aug 20, 2021

Oh, and if you don't want git issues here I can disable it again. I thought it was nice to keep them away from the app issues.

@gornostal
Copy link
Member

Oh, and if you don't want git issues here I can disable it again. I thought it was nice to keep them away from the app issues.

That's fine. I agree!

Releases part is cached

That's intended because Github API has a request limits for non-authenticated requests. I'm caching it the releases for 2 minutes in browser's local storage.
This shouldn't be an issue for regular users.

@friday
Copy link
Member Author

friday commented Aug 27, 2021

I think it's happening before that. The cache never checked the GitHub releases url. I lasted for hours and only checked again when I force-reloaded. I guess I can check again next time I make a release.

@friday
Copy link
Member Author

friday commented Jan 15, 2023

Update about this: I just pushed a new change to fix and improve the debian instructions further, and the new git action worked, so they're published 👍

When I went to check the site, it was still showing the old info, and in the network requests it had the old cached version from November 13. Opening an incognito window worked though, as well as disabling cache in devtools and reloading.

Maybe it's more of an inconvenience than a real issue.

Screenshot from 2023-01-15 15-28-23

@gornostal
Copy link
Member

I ran "cache invalidation" in cloudfront. This should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants