[BUG] zdbsp compressed UDMF nodes configuration produces uncompressed nodes

[kitchen-ace]

This is probably a bug with zdbsp, but as a workaround in UDB is fairly easy, I decided to just report here now too.

zdbsp requires the options -X -z in that order to produce compressed extended nodes.
using -z -X, as UDB does currently, will produce uncompressed extended nodes.

tested with Linux and Windows (through Wine) versions of zdbsp as well as UDB.

ZDoom/gzdoom#2658

[biwa]

According to the ZDoom Wiki:

--compress or -z
Compresses the node information. Compressed nodes are identical to extended nodes, but they take up less space. If GL nodes are built, they will be compressed as well.

So compressed nodes always seem to be extended nodes. A quick check on a simple test map reinforces that:

-z      ZGLN header   209 bytes ZNODES
-X      XGLN header    468 bytes ZNODES
-z -X   XGLN header    468 bytes ZNODES
-X -z   ZGLN header    209 bytes ZNODES

So I'd say that the -X parameter can be completely dropped from all the configs that use -z. That'd also make a bunch of them superfluous, like this would have the exact same options:

zdbsp_compressed
{
	title = "ZDBSP - Compress nodes";
	compiler = "zdbsp";
	parameters = "-z -o%FO %FI";
}

zdbsp_udmf_compressed
{
	title = "ZDBSP - Compress nodes (UDMF)";
	compiler = "zdbsp";
	parameters = "-z -X -o%FO %FI";
}

[kitchen-ace]

You're right, whichever of -z and -X (and -Z) is passed last takes priority, as they all control the same internal options.

https://github.com/ZDoom/zdbsp/blob/master/main.cpp#L385

[biwa]

Simply removing the useless settings poses a bit of an inconvenience, since it'll leave the setting blank in the editor:

And when trying to save (or probably playtest - didn't test that) it'll complain that the nodebuilder can't be found. Maybe it should just fall back to the default nodebuilder setting in the game config in that case.

[kitchen-ace]

Maybe it should just fall back to the default nodebuilder setting in the game config in that case.

Does that mean switching nodebuilders for game configs that default to zennode? Probably good to give a warning in that case.

(why is zennode still the default for Doom/Boom/etc. anyhow?)