Number of players is ignored when the first (or only) song in the song selection is a duet (always 6 players)

[bohning]

Steps to reproduce:

• Start USDX with just a duet song
• Set number of players !=6 (e.g. 2)
• Enter song selection

What it should look like if two players are selected:

[barbeque-squared]

I think the problematic code is UScreenSong in the SetScroll function. Well, I'd say that whole file is problematic, but specifically what's happening here is that in the // Duet Singers part it's only setting to visible what it needs (if it's a Duet), and the only time it hides things is if the song is not a Duet (the else towards the end).

When it does the AddStatic etc calls in Create I don't know which AddStatic path in UMenu it takes exactly, but just search for Statics[StatNum].Visible := true; in there. It's probably not the worst default to make them visible.

The least bad solution in the current code would be to explicitly set .Visible := false in the Create function, after each AddStatic / AddText call.