Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the global variable logger to comet_logger #210

Open
vince62s opened this issue Apr 3, 2024 · 1 comment
Open

Change the global variable logger to comet_logger #210

vince62s opened this issue Apr 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@vince62s
Copy link

vince62s commented Apr 3, 2024

The point lies here: https://github.com/Unbabel/COMET/blob/master/comet/__init__.py#L22

When we import anything like "from comet import load_from_checkpoint" it will create a global variable "logger" and there are consequences if in the main code calling this import we also have a variable "logger".

Since the likelihood is more "calling comet from another toolkit" rather than the contrary, I would like to rename the logger variable to comet_logger which has to happen only in a few instances.

Do you agree?

@vince62s vince62s added the enhancement New feature or request label Apr 3, 2024
@ricardorei
Copy link
Collaborator

I agree. I don't see any reason why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants