Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Choice] Option to hide not picked games from Subscriptions tab (despite I have some choices left) #124

Open
DPSB opened this issue Jun 29, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@DPSB
Copy link

DPSB commented Jun 29, 2020

Describe the bug
Im seeing not claimed games now in my library.
So for example:
I have the humble choice subscription and im allowed to pick 10 games out a list of 12. But with the new "subscriptions" tab in gog, i see all 12 choices as if i would own all 12 games.

Expected behavior
I should only see the games which i own.

Plugin installed
updated directly from gog

Note:
I dont even see the reason behind this new subscription tab. I dont like to see my games now twice in "Subscriptions" and "Humble Bundle". Whats the benefit of this new tab? Is there any way to deactivate the subscriptions part? So that i dont see this tab in the gog ui?

@DPSB DPSB added the bug Something isn't working label Jun 29, 2020
@UncleGoogle
Copy link
Owner

UncleGoogle commented Jun 30, 2020

The plugin logic is as follows:

  • subscription games are reported separately from owned games
  • if you have some game picks left for given Choice month, plugin sends all month choices
  • if you have 0 game picks left for given Choice month, plugin sends only those already chosen

More info behind this: #73

So

i see all 12 choices as if i would own all 12 games.

you probably has filter checked for subscription games altogether with owned games.

Note:
I dont even see the reason behind this new subscription tab.
I dont like to see my games now twice in "Subscriptions" and "Humble Bundle".

Do you mean this generic one that gathers all subscription games reported from all plugins https://i.gyazo.com/7af071f0186f441a2c82bb7ebad255ed.png ?

Whats the benefit of this new tab? Is there any way to deactivate the subscriptions part?
So that i dont see this tab in the gog ui?

Ask Galaxy team.

As far as I know you can deselect Humble subscriptions from Settings-Platforms-Features. But you need to it for every month. I don't know method to disable Subscriptions tab for all plugins, it is out of my power.

@piber20
Copy link

piber20 commented Jul 4, 2020

It's much more convenient to me to display games which I currently have access to. The plugin still displays unchosen games from months past for me. For example, Gris shows up in my subscriptions tab, owned only on the humble platform, as part of that subscription category. Even still, I have entries for games that galaxy lists as "technically owned", but I cannot even play them or obtain a key to get them on steam through the install method. The subscription entries being there implies to me that I can access them because I'm subscribed to the service, but I can't.

Here's something I propose: displaying only the choice games for the current month, for games the user hasn't chosen yet, and only if the user hasn't fully expended their 9 choices yet. Don't display choice games from previous months

This would be a good way to display what can potentially be played at the moment as part of the subscription service, as the month being over or the 9 choices being used would lock you into those games afterward.

Removing games from the list as they are chosen would also help to avoid confusing situations like this one, in the case of a game that gave a steam key but also a DRM free copy on humble:
Untitled

EDIT: My mistake, it seems gog galaxy adds a drop down after you disable the show subscriptions tickbox, letting me disable specific categories. I still think what I proposed could be a good thing to consider as an alternative way to display choice games, though.

@UncleGoogle
Copy link
Owner

UncleGoogle commented Jul 4, 2020

Thanks for proposal. I need to group all needs and propose something universal and not overcomplicated. See also #123

But do you know that you can still reedem games from previous months if you have some choices left? The chooice is not limited to current month (like playstation plus). And as you noticed you can disable previous months.

As a side note you need to know that subscription games are in separation from owned games return by plugin. So even if you disable subscription games for one month, the already chosen games should be returned as regular owned games so you see them in Galaxy (but without Humble Choice xxx mark)

@piber20
Copy link

piber20 commented Jul 4, 2020

But do you know that you can still reedem games from previous months if you have some choices left?

Oof. Didn't know about that.

@UncleGoogle UncleGoogle changed the title Humble Subscriptions [Choice] Option to hide not picked games from Subscriptions tab (despite I have some choices left) Sep 7, 2020
@UncleGoogle UncleGoogle added enhancement New feature or request and removed bug Something isn't working labels Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants