Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing install button in main window and subscrition settings also -- no way to re-configure the plugin #167

Open
Corbian opened this issue Jan 17, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@Corbian
Copy link

Corbian commented Jan 17, 2022

Hi, thanks for this plugin UncleGoogle !

Describe the bug

  • In the main GOG Galaxy screen, when I switch to "Humble Bundle" view, the "Install" button is not showing as explained in the readme.
    HB-GOG-main

  • In the settings dialog, "Features" section, the only setting in the "Humble Bundle" is the "Metadata", there's nothing about subscriptions as shown in the readme.
    HB-GOG-plugin

Expected behavior
Something to access the plugin settings, as explained in the readme (Install button, and subscription settings available)
I saw the configuration window once when I started the plugin the first time, but now I feel screwed 😕

Plugin installed
today, directly from Galaxy, the log says ver 0.9.5
using Galaxy ver 2.0.45.61 (updated December 21st 2021)

Provide logs

  • is this needed ? how can I trim the parts disclosing which games I own ?
@Corbian Corbian added the bug Something isn't working label Jan 17, 2022
@UncleGoogle
Copy link
Owner

Hi, I know about problem. This should be fixed by #138 once done.
I've just put one more commit, it would be great if you could test this build:
https://github.com/UncleGoogle/galaxy-integration-humblebundle/releases/tag/v9.5-dev1
Installation instruction is in Readme.

To recall configuration window click twice on Install button for any humble game.

@ChocoSauce
Copy link

Hi, I know about problem. This should be fixed by #138 once done. I've just put one more commit, it would be great if you could test this build: https://github.com/UncleGoogle/galaxy-integration-humblebundle/releases/tag/v9.5-dev1 Installation instruction is in Readme.

To recall configuration window click twice on Install button for any humble game.

I tried the new update and it still only shows the metadata option with no subscriptions list.

@UncleGoogle
Copy link
Owner

UncleGoogle commented Feb 5, 2022

try to disconnect and reconnect again - similar problem was caused by Galaxy some time ago - I mean, that not only plugin update was needed but also reconnection.

If the problem still occur, please drop me the log file:
plugin-humble-f0ca3d80-a432-4d35-a9e3-60f27161ac3a.log.txt and plugin-humble-f0ca3d80-a432-4d35-a9e3-60f27161ac3a.log.txt.1

all sensitive data (gamekeys) should be trimmed automatically. @Corbian - You can also remove lines with your games manually.

@Corbian
Copy link
Author

Corbian commented Feb 5, 2022

Sorry for the long delay to answer 🕰
@UncleGoogle
I've disconnected the plugin in Galaxy, then closed the client.
Updated the files to the v9.5-dev1 you linked (erasing everything in the folder before).
Re-started Galaxy and re-connected the plugin.
Noticed the % increasing up to 4% then down to 0% (one by one), then went up again to 100%.
Sadly, no change seen in the setting dialog, only the metadata is shown as in my previous screenshot.

To recall configuration window click twice on Install button for any humble game.

Found it. But it works only if the game is not also owned on another platform.
For example I own games both on HB and Epic : in this situation, it opens the Epic launcher and asks where to install the game (if not already on disk). That's why I didn't got it the first time 🙄

Additionally, it shows at least one software and one game for which I revealed the keys, but i didn't checked that box when importing ! No time now to investigate more one that, sorry.

@UncleGoogle
Copy link
Owner

Sadly, no change seen in the setting dialog, only the metadata is shown as in my previous screenshot.

thanks for checking. Bad news. But I can't check when have no logs. Please sent to me something, otherwise I can't fix that.

Noticed the % increasing up to 4% then down to 0% (one by one), then went up again to 100%.

that is expected - sadly Galaxy doesn't deal well with the importing of games via add_game notification the API provides. Galaxy % progress bar works the best when all games are imported in one batch from get_owned_games method which is called by Galaxy on predefined moments. This plugin uses add_game/remove_game notifications to be able to manage different set of games (keys, drm-free ect) depending on user settings.

Found it. But it works only if the game is not also owned on another platform.
For example I own games both on HB and Epic : in this situation, it opens the Epic launcher and asks where to install the game (if not already on disk)

Galaxy deduplicates different games versions/releases from different platforms and put all of them under one view. IIRC it prefers 1) installed game 2) GOG game to be shown by default To select different release/game version from different store select icon like this:
4334164b106d9491495b1243b9e6d04a

if you think you can extend the Readme instruction to mention this UI trap, then PR are welcomed.

Additionally, it shows at least one software and one game for which I revealed the keys, but i didn't checked that box when importing

when you have some time, please create separate issue for that. I can't guess what happen without logs unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants