Humble App support #174
Merged
Humble App support #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging ec813d5 into eb17cfa - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 417b184 into eb17cfa - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 6ba55d4 into eb17cfa - view on LGTM.com fixed alerts:
|
it is due to wrong annotation in plugins API, see python/mypy#5385 (comment)
|
This pull request fixes 1 alert when merging 9d9995b into eb17cfa - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169
Closes #170 (the only missing thing is list of humble collection games when humble App is not installed locally)
I've tried to implement also getting last played times, but apparently Galaxy does not imports game times for subscription games.The workaround would be to return humbleapp games as regular owned games.
For now I rejected this idea as their presence rely on humbleapp client installed (so in case of having to plugin installed - one one machine with installed humbleapp client -- second one on the machine w/o it - would produce infinite conflict on GOG backends). Subcription games interface is free of this problem as I can raise error instead of returning empty list of games, and then Galaxy does not remove them from user library.