Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externally opened videoes cause non transparent & underlapping player design #588

Open
lkd70 opened this issue May 31, 2018 · 1 comment

Comments

@lkd70
Copy link

lkd70 commented May 31, 2018

Description

When opening a video from an external source (e.g: File Manager) in LeafPic video player, the control bars (top and bottom) show in the primary color, opposed to the normal transparent black color. The video will also overlap the top control bar

Steps to reproduce

  1. Open an external media source (e.g: File Manager), locate a portrait video
  2. Open the video in Leaf Pic Video Player
  3. Turn the app in to landscape mode(examples)

Expected result

The player controls overlap the video when open
The player controls are translucent and black, not Primary Color.

Actual result

The player controls are overlapped by the video when the player is in landscape mode, but is a portrait video.
The player controls are Primary Color and not transparent.
see examples

Additional Information

  • App version: v0.6-beta-1
  • Android version: 8.1.0
  • Android ROM: OxygenOS 5.1.1

Examples

image showing both issues

@dnldsht
Copy link
Member

dnldsht commented May 31, 2018

the control bars (top and bottom) show in the primary color, opposed to the normal transparent black color

The ViewPager (the activity when you can scroll images) is different from the VideoPlayerActivity this explain the not transparent bars.

I don't know if is a good idea to move the VideoPlayer in a Fragment and show it in the ViewPager..
@calvinnor would love to hear your thoughts on this.

Edit: for the overlapping issue would be easy to fix!

dnldsht added a commit that referenced this issue Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants