Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build clang in Release #46

Open
kymikoloco opened this issue May 17, 2019 · 0 comments · May be fixed by #47
Open

Build clang in Release #46

kymikoloco opened this issue May 17, 2019 · 0 comments · May be fixed by #47
Labels
pr-available

Comments

@kymikoloco
Copy link

The clang-format Dockerfile builds clang in Debug, it should probably build in Release:

https://github.com/Unibeautify/docker-beautifiers/blob/master/clang-format/Dockerfile#L19

-RUN cmake -GNinja -DLLVM_BUILD_STATIC=ON -DLLVM_ENABLE_LIBCXX=ON ..
+RUN cmake -GNinja -DLLVM_BUILD_STATIC=ON -DLLVM_ENABLE_LIBCXX=ON -DCMAKE_BUILD_TYPE=Release ..

Docker for some reason would be unable to compile and would kill the c++ process if its in Debug (it's also slower to compile)
More info here: https://llvm.org/docs/Docker.html
@stevenzeck stevenzeck linked a pull request May 24, 2019 that will close this issue
Open
@helpr helpr bot added the pr-available label May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build clang-format from release instead of debug Unibeautify/docker-beautifiers
1 participant
@kymikoloco