Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTTP redirects properly #53

Open
lesserwhirls opened this issue Aug 18, 2015 · 1 comment
Open

Handle HTTP redirects properly #53

lesserwhirls opened this issue Aug 18, 2015 · 1 comment

Comments

@lesserwhirls
Copy link
Collaborator

To be consistent with other services, TDS 5.0 serves out all catalogs using

thredds/catalog

The top level catalog's old url:

thredds/catalog.(html|xml)

redirects to:

thredds/catalog/catalog.(html|xml)

which siphon catches. However, the TDSCatalog object still has the old url, and thus any relative catalogRefs are constructed incorrectly (except for catalogRefs generated by catalogScan elements). For example, a TDS 5.0 catalogRef to forecastModels.xml is turned into an absolute URL of:

/thredds/forecastModels.xml

instead of the new, correct absolute URL of:

/thredds/catalog/forecastModels.xml

A request to the old absolute URL does not get a redirect, and thus fails with a 404.

Perhaps the correct thing to do here is check for the redirect to set the catalog objects "cat_url" attribute in TDSCatalog and make sure that absolute URLs for catalogRefs are built with the correct url. This should keep backwards compatibility with TDS <= 4.6 while future proofing for TDS 5.0.

@dopplershift dopplershift modified the milestone: Summer 2017 May 31, 2017
@dopplershift dopplershift modified the milestone: 0.5 Jul 19, 2017
@lesserwhirls lesserwhirls changed the title Support TDS 5.0 new Catalog URLs Handle HTTP redirects properly Mar 30, 2018
@lesserwhirls
Copy link
Collaborator Author

The real issue is that we do not handle http redirects properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants