From b8409f03e6fb06635181cd2b61df4d3fa7a39358 Mon Sep 17 00:00:00 2001 From: Sara Reynolds Date: Wed, 27 Nov 2024 22:46:42 -0500 Subject: [PATCH 1/2] use address for subscriber --- src/base/Notifier.sol | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/base/Notifier.sol b/src/base/Notifier.sol index 3412ea645..7e755c660 100644 --- a/src/base/Notifier.sol +++ b/src/base/Notifier.sol @@ -96,32 +96,28 @@ abstract contract Notifier is INotifier { uint256 liquidity, BalanceDelta feesAccrued ) internal { - ISubscriber _subscriber = subscriber[tokenId]; + address _subscriber = address(subscriber[tokenId]); // remove the subscriber delete subscriber[tokenId]; - bool success = _call( - address(_subscriber), abi.encodeCall(ISubscriber.notifyBurn, (tokenId, owner, info, liquidity, feesAccrued)) - ); + bool success = + _call(_subscriber, abi.encodeCall(ISubscriber.notifyBurn, (tokenId, owner, info, liquidity, feesAccrued))); if (!success) { - address(_subscriber).bubbleUpAndRevertWith( - ISubscriber.notifyBurn.selector, BurnNotificationReverted.selector - ); + _subscriber.bubbleUpAndRevertWith(ISubscriber.notifyBurn.selector, BurnNotificationReverted.selector); } } function _notifyModifyLiquidity(uint256 tokenId, int256 liquidityChange, BalanceDelta feesAccrued) internal { - ISubscriber _subscriber = subscriber[tokenId]; + address _subscriber = address(subscriber[tokenId]); bool success = _call( - address(_subscriber), - abi.encodeCall(ISubscriber.notifyModifyLiquidity, (tokenId, liquidityChange, feesAccrued)) + _subscriber, abi.encodeCall(ISubscriber.notifyModifyLiquidity, (tokenId, liquidityChange, feesAccrued)) ); if (!success) { - address(_subscriber).bubbleUpAndRevertWith( + _subscriber.bubbleUpAndRevertWith( ISubscriber.notifyModifyLiquidity.selector, ModifyLiquidityNotificationReverted.selector ); } From c74a3152b672eea7706b87ea129b7bde75a9e265 Mon Sep 17 00:00:00 2001 From: Sara Reynolds Date: Mon, 2 Dec 2024 11:30:39 -0500 Subject: [PATCH 2/2] fix bytecode snap --- .forge-snapshots/positionDescriptor bytecode size.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.forge-snapshots/positionDescriptor bytecode size.snap b/.forge-snapshots/positionDescriptor bytecode size.snap index 4cdd5179a..616fe5514 100644 --- a/.forge-snapshots/positionDescriptor bytecode size.snap +++ b/.forge-snapshots/positionDescriptor bytecode size.snap @@ -1 +1 @@ -24108 \ No newline at end of file +24177 \ No newline at end of file