Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep thisInstance modifications in controller-specific tests #2563

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

IlyaMuravjov
Copy link
Collaborator

Description

In controller-specific integration tests thisInstance modifications were lost (i.e. saving data to database, invoking controller methods before method under test), this PR restores such modifications.

How to test

Manual tests

Generate tests on the example from #2562, there should be tests that save data to database directly or use controller methods to do that.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added ctg-bug-fix PR is fixing a bug comp-spring Issue is related to Spring projects support labels Aug 28, 2023
@EgorkaKulikov EgorkaKulikov merged commit 9f849b3 into main Aug 28, 2023
35 of 37 checks passed
@EgorkaKulikov EgorkaKulikov deleted the ilya_m/controller_modifications branch August 28, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-spring Issue is related to Spring projects support ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants